alphaTab icon indicating copy to clipboard operation
alphaTab copied to clipboard

TabBrushGlyph have Bug: when 6str Note heighter than 5str Will happen

Open goodgame365 opened this issue 3 years ago • 0 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

the erro like: 未命名-3

Expected Behavior

The right one should be like this

未命名-5

Steps To Reproduce

the err file here sb.zip

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.2

Platform

Node.js

Environment

- **Browser**:chrome

Anything else?

I found TabBrushGlyph.ts on 24 line begin may be wrong:

  let startY: number =
        cy + this.x + (tabBarRenderer.getNoteY(this._beat.maxNote!, NoteYPosition.Top));
    let endY: number =
        cy + this.y + tabBarRenderer.getNoteY(this._beat.minNote!, NoteYPosition.Bottom);

this._beat.maxNote! and this._beat.minNote! is erro Should be changed to


this._beat.maxStringNote! and this._beat.minStringNote!


Complete code:


  let startY: number =
        cy + this.x + (tabBarRenderer.getNoteY(this._beat.maxNote!, NoteYPosition.Top));
    let endY: number =
        cy + this.y + tabBarRenderer.getNoteY(this._beat.minStringNote!, NoteYPosition.Bottom);

goodgame365 avatar Jul 29 '22 10:07 goodgame365