rsync-deployments icon indicating copy to clipboard operation
rsync-deployments copied to clipboard

Improve shell script robustness and error handling

Open nils-kt opened this issue 1 year ago • 3 comments

  • Added set -euo pipefail to ensure the script exits on errors, undefined variables, or failed pipelines.
  • Enhanced error handling for SSH agent start and key addition, with clear error messages.
  • Replaced echo with printf for more reliable and formatted output.
  • Introduced optional legacy RSA hostkey handling based on input parameters.
  • Improved overall script readability with clearer variable names and structured conditionals.

nils-kt avatar Aug 22 '24 18:08 nils-kt

Thank you for your contribution! Will review it

Burnett01 avatar Aug 22 '24 19:08 Burnett01

@Burnett01 any news?

nils-kt avatar Sep 02 '24 12:09 nils-kt

looks good so far, I will get back to you

Burnett01 avatar Sep 17 '24 19:09 Burnett01