Consider a sticky header for MR page for mobile / narrow viewports
Proposal
There should be a sticky header for the MR page on mobile. Originally this concern was raised in !193105 (merged) to address file diff navigation however this could also include access to the "your review" as well.
Common thing here seems to be how might we open drawers of information in the MR on mobile.
Background
In Merge request sticky header (#365895 - closed) there was a discussion to not have a sticky header at narrow viewports.
Context
When reviewing an MR, sometimes its helpful to swap between inline vs side by side views. Unfortunately this control is not preserved in the sticky header, which means that the user has to scroll all the way up to change the type.
The "Your review" button is wrapping incorrectly at viewport width sizes of 861-890px.
There is no sticky header so this means users would have to scroll back up to the top to access the review button when panels are open
The following discussion from !193105 (merged) should be addressed:
-
@mle started a discussion: (+1 comment)
@slashmanov question in mobile on the Changes tab what should be sticky?
Currently what I see in the mobile view is something like this on initial load
Would something like this make sense to be be sticky for the Changes tab?
As for the icon to open the files to differentiate from the sidebar itself, what if we used the icon that the files are listed either tree or list
Tree List
I still think you should not waste so much screen space (on a smaller screen) when somebody does a review. They want to see as much code as possible, in order to avoid scrolling, and there is no use to occupy so much of the screen with just white canvas.
