Merge Request Approval confusing UI after rebase

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Summary

Gitlab Merge Request user interface is confusing in situations when a developer other than author of the MR both approves the MR and after that does a rebase in the MR.

The user interface shows the approval from this developer but still complains about missing developer approvals.

Steps to reproduce

• Create a project
• Make sure the correct merge request settings are enabled
  • Require at least 1 approval in MRs
  • Prevent approval by author
  • Prevent approvals by users who add commits
  • Prevent editing approval rules in merge requests
  • When a commit is added: Remove all approvals
• Add a developer B to the project
• Create an MR with Developer A (main -> feature-branch)
• Make changes to main with Developer A
• Switch to Developer B
• Approve the MR as Developer B
• Rebase the MR with Developer B
• Notice how the UI now doesn't show any indication that further approvals are needed.
• After a browser refresh, the UI shows the need for approvals, but it still shows the "Approved by you" label.

Example Project

I was able to reproduce this in the following project:

• MR approval rules after rebase (GitLab Team Members Only - Please ping me if you need access, and I'll add you 😊 )

What is the current bug behavior?

After a rebase, the user interface shows the approval from this developer but still complains about missing developer approvals.

What is the expected correct behavior?

After a rebase, the user interface should only mention the missing developer approvals.