Show the same resolve controls for regular and diff threads

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Proposal

This proposal addresses the following items

• Making resolved status of threads look similar for comments and diffs
• Handle single comment thread when resolved #548113 (closed)

Proposed changes

1. Use a badge " Resolved" for all threads in the resolved state
   1. The badge serves as an indicator of the resolved state. It was considered to use the "resolve" button since is minimal but reopening a thread without context of thread was the concern #483952 (comment 2100865264).
   2. Debating if we should sticky with icon button #483952 (comment 2955351731)
2. Overflow menu provides a way to link to comment
3. Changing "X replies" to "Show thread" avoids situation currently where we count the replies differently when it is a thread and a diff thread. With a diff thread it counts the comment as a reply too.
   • Currently if there 2 replies to a comment on a diff thread, it will say "3 replies"
4. Display file path on collapsed state of diff thread will help give context which comment was collapsed
   1. Based on discussions in this issue on changing "file" to a filepath
   2. Order of information is considering this comment #560513[open_threads.png] (comment 2795832506) "I still prefer using dates to navigate to a particular thread".
5. Introduces a collapsed state to resolved threads that appear on Overview tab since these comments could have images and other content that currently remain expanded
   1. Show a truncated preview of comment
   2. Not all comment could be truncated if it is a non-text content so will propose to display "Comment with content hidden" as a generic handler (see Egde cases below)

Designs

Figma > Comments and Diffs

There shouldn't be any major spacing/padding changes. Any deviations you see in the mockups and Figma from what is in production today can be ignored unless it is new additions.

Resolved threads

State	Current	Proposal
Thread resolved
Diff resolved
Single comment thread resolved

Threads - States

Expanded	Collapsed	Resolved Collapsed	Resolved Expanded

Diff - States

Expanded	Collapsed	Resolved Collapsed	Resolved Expanded

Single comment thread - States

Addresses this issue Make closed threads without answers look simila... (#548113 - closed)

Expanded	Resolved Collapsed	Resolved Expanded

Edge cases

When content begins with an image, table, or a media type that cannot be truncated, will display "Comment with content hidden". Only upon expanding this thread will the content be visible

Background

The following discussion from !165005 (merged) should be addressed:

• @slashmanov started a discussion: (+3 comments)

  @seggenberger WDYT of providing the same resolved status for diff threads as for the regular ones?

  

  Right now it's not consistent: