Remove upload params from body params

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Summary

Follow up issue from gitlab-workhorse!490 (merged), upload params are sent twice:

1. as body params
2. as a signed JWT param

(1.) can be dropped and let rails read them from (2.) only.

Improvements

• With gitlab-workhorse!490 (merged), saved_file_tacker.go is setting the same params twice. Removing (1.) from the above will simplify the code.
• Uploaded requests forwarded to rails will be lighter.

Risks

• ⚠️ Before dealing with this issue, make sure that rails exclusively use (2.) (through multipart.rb)
• Uploads can be broken by these changes. Make sure to verify them with a good set of different uploads. Here is an example: gitlab-workhorse!490 (merged)
• The use of a feature flag is advised.

Involved components

• saved_file_tacker.go