Commit cd96f133 authored by Cynthia "Arty" Ng's avatar Cynthia "Arty" Ng 💬
Browse files

Add relative links rule

parent 71a23a4e
Loading
Loading
Loading
Loading
+13 −0
Original line number Diff line number Diff line
---
# Error: handbook.RelativeLinks
#
# Checks for the presence of absolute hyperlinks that should be relative.
#
# For a list of all options, see https://vale.sh/docs/topics/styles/
extends: existence
message: "Use a relative link instead of the full URL."
link: https://docs.gitlab.com/ee/development/documentation/styleguide/index.html#links
level: error
scope: raw
raw:
  - '\[[^\]]+\]\(https?:\/\/handbook\.gitlab\.com\/.*?\)'

.vale/handbook/Uppercase.yml

deleted100644 → 0
+0 −267
Original line number Diff line number Diff line
---
# Suggestion: handbook.Uppercase
#
# Checks for use of all uppercase letters with unknown reason.
#
# For a list of all options, see https://vale.sh/docs/topics/styles/
extends: conditional
message: "Instead of uppercase for '%s', use lowercase or backticks (`) if possible. Otherwise, submit a MR to add the word or acronym to the rule's exception list."
link: https://docs.gitlab.com/ee/development/documentation/testing/vale.html#vale-uppercase-acronym-test
level: suggestion
ignorecase: false
# Ensures that the existence of 'first' implies the existence of 'second'.
first: '\b([A-Z]{3,5})\b'
second: '(?:\b[A-Z][a-z]+ )+\(([A-Z]{3,5})\)'
# ... with the exception of these:
exceptions:
  - ACL
  - AJAX
  - ALL
  - AMI
  - ANSI
  - APAC
  - API
  - APM
  - ARM
  - ARN
  - ASCII
  - ASG
  - AST
  - AWS
  - BETA
  - BMP
  - BSD
  - CAS
  - CDN
  - CGI
  - CIDR
  - CLI
  - CNA
  - CNCF
  - CORE
  - CORS
  - CPU
  - CRAN
  - CRIME
  - CRM
  - CRUD
  - CSRF
  - CSS
  - CSV
  - CTE
  - CVE
  - CVS
  - CVSS
  - CWE
  - DAG
  - DAST
  - DDL
  - DHCP
  - DML
  - DNS
  - DSN
  - DOM
  - DORA
  - DSA
  - DSL
  - DUOPRO
  - DUOENT
  - DVCS
  - DVD
  - EBS
  - ECDSA
  - ECS
  - EFS
  - EKS
  - ELB
  - ENA
  - EOL
  - EWM
  - EXIF
  - FAQ
  - FIDO
  - FIFO
  - FIPS
  - FLAG
  - FOSS
  - FQDN
  - FREE
  - FTP
  - GCP
  - GDK
  - GDPR
  - GET
  - GID
  - GIF
  - GKE
  - GLEX
  - GLFM
  - GNU
  - GPG
  - GPL
  - GPS
  - GPT
  - GPU
  - GUI
  - HAML
  - HAR
  - HDD
  - HEAD
  - HIPAA
  - HLL
  - HSTS
  - HTML
  - HTTP
  - HTTPS
  - IAM
  - IANA
  - IBM
  - ICO
  - IDE
  - IID
  - IIS
  - IMAP
  - IOPS
  - IRC
  - ISO
  - JPEG
  - JPG
  - JSON
  - JVM
  - JWT
  - KICS
  - LAN
  - LDAP
  - LDAPS
  - LESS
  - LFS
  - LRU
  - LSIF
  - LTM
  - LTS
  - LVM
  - MIME
  - MIT
  - MITRE
  - MVC
  - NAS
  - NAT
  - NDA
  - NFS
  - NGINX
  - NOTE
  - NPM
  - NTP
  - OCI
  - OIDC
  - OKD
  - OKR
  - ONLY
  - OSS
  - OTP
  - OWASP
  - PAT
  - PCI-DSS
  - PDF
  - PEM
  - PEP
  - PGP
  - PHP
  - PID
  - PKCS
  - PNG
  - POSIX
  - POST
  - PROXY
  - PUT
  - QPS
  - RAID
  - RAM
  - RBAC
  - RDP
  - RDS
  - RDS
  - REST
  - RFC
  - RHEL
  - RPC
  - RPM
  - RPO
  - RPS
  - RSA
  - RSS
  - RTC
  - RTO
  - RVM
  - SAAS
  - SAML
  - SAN
  - SAST
  - SATA
  - SBOM
  - SBT
  - SCIM
  - SCM
  - SCP
  - SCSS
  - SDK
  - SELF
  - SEO
  - SFTP
  - SHA
  - SKI
  - SLA
  - SLI
  - SLO
  - SMS
  - SMTP
  - SOAP
  - SOC
  - SOX
  - SPDX
  - SPDY
  - SPF
  - SQL
  - SRE
  - SSD
  - SSG
  - SSH
  - SSL
  - SSO
  - STI
  - SUSE
  - SVG
  - SVN
  - TCP
  - TIFF
  - TIP
  - TLD
  - TLS
  - TODO
  - TOML
  - TOTP
  - TPS
  - TTL
  - UBI
  - UDP
  - UID
  - UID
  - UNIX
  - URI
  - URL
  - USB
  - UTC
  - UTF
  - UUID
  - VCS
  - VPC
  - VPN
  - WAF
  - WEBP
  - WIP
  - WSL
  - XML
  - XSS
  - YAML
  - ZAP
  - ZIP
+1 −1
Original line number Diff line number Diff line
##### Development

* The Principal Engineer role acts as the individual equivalent of a Senior Engineering Manager, Development.
* Extends that of the [Staff Frontend Engineer](https://handbook.gitlab.com/job-families/engineering/development/frontend#staff-frontend-engineer) or the [Staff Backend Engineer](https://handbook.gitlab.com/job-families/engineering/development/backend/#staff-backend-engineer) responsibilities
* Extends that of the [Staff Frontend Engineer](/job-families/engineering/development/frontend#staff-frontend-engineer) or the [Staff Backend Engineer](/job-families/engineering/development/backend/#staff-backend-engineer) responsibilities
* Collaborates and makes proposals across several teams on their engineering work, and helps their team members make informed decisions in alignment with the sub-department strategic plans.
* Exposes technology and organizational needs across their sub-department.
* Teach, mentor, grow, and provide advice to other domain experts, individual contributors, across several teams in their sub-department.
+17 −17
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ During the FCL, the team(s) exclusive focus is around [reliability work](#scope-
- Hold a synchronous `closing ceremony` upon completing the FCL to review the retrospectives and celebrate the learnings.
  - All FCL stakeholders and participants shall attend or participate async.  Managers of the groups participating in the FCL, including Sr. EMs and Directors should be invited.
  - Agenda includes reviewing FCL retrospective notes and sharing learnings about improving code change quality and reducing risk of availability.
    - Outcome includes [handbook](https://handbook.gitlab.com/handbook/) and [GitLab Docs](https://docs.gitlab.com/ee/) updates where applicable.
  - Outcome includes [handbook](/handbook/) and [GitLab Docs](https://docs.gitlab.com/ee/) updates where applicable.

##### Scope of work during FCL

+1 −12
Original line number Diff line number Diff line
---

title: "Merge Request Roles and Responsibilities"
description: "GitLab Data Team MR responsibilities"
---









---

## <i class="fas fa-users fa-fw color-orange font-awesome" aria-hidden="true"></i>Merge Request Roles and Responsibilities
@@ -96,7 +85,7 @@ Every MR follows the applicable MR template. When a MR is ready for review, assi

#### Merge Request approval requirements

Because of quality and [security](https://handbook.gitlab.com/handbook/security/gitlab_projects_baseline_requirements/#mr-approval-rule-configurations) we require every MR to be approved before merged with multiple Team Members involved. By default the CODEOWNER file sets that an approval is needed and by who. But if a file or folder is not present in the CODEOWNER file a MR still can be merged without approval or without other Team Members involvement. To enforce the following 2 settings must be applied on each project within the [GitLab-Data Group](https://gitlab.com/gitlab-data/).
Because of quality and [security](/handbook/security/gitlab_projects_baseline_requirements/#mr-approval-rule-configurations) we require every MR to be approved before merged with multiple Team Members involved. By default the CODEOWNER file sets that an approval is needed and by who. But if a file or folder is not present in the CODEOWNER file a MR still can be merged without approval or without other Team Members involvement. To enforce the following 2 settings must be applied on each project within the [GitLab-Data Group](https://gitlab.com/gitlab-data/).

1. `Approvals required` = `1`
[setting 1](/handbook/business-technology/data-team/how-we-work/sett1.png)
Loading