Remove obsolete CXX_STD = CXX11 to allow Armadillo 15.0.x migration#14
Merged
zzawadz merged 2 commits intozzawadz:masterfrom Jan 5, 2026
Merged
Remove obsolete CXX_STD = CXX11 to allow Armadillo 15.0.x migration#14zzawadz merged 2 commits intozzawadz:masterfrom
zzawadz merged 2 commits intozzawadz:masterfrom
Conversation
Closed
34 tasks
eddelbuettel
commented
Jan 5, 2026
Contributor
Author
eddelbuettel
left a comment
There was a problem hiding this comment.
I recommend to change this.
| @@ -1,2 +1,2 @@ | |||
| PKG_LIBS = $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS) $(SHLIB_OPENMP_CXXFLAGS) | |||
| PKG_LIBS = $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS) `"${R_HOME}/bin${R_ARCH_BIN}/Rscript" -e "RcppArmadillo:::CxxFlags()"` $(SHLIB_OPENMP_CXXFLAGS) | |||
Contributor
Author
There was a problem hiding this comment.
This is wrong/obsolete/unnecessary. You do not need CxxFlags() from RcppArmadillo as R gives it to you via the LinkingTo: flag from DESCRIPTION.
| @@ -1,3 +1,3 @@ | |||
| PKG_LIBS += $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS) | |||
| PKG_LIBS += $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS) $(shell "${R_HOME}/bin${R_ARCH_BIN}/Rscript.exe" -e "RcppArmadillo:::CxxFlags()") | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Armadillo 15.0.* now makes C++14 the minimum compilation standard. For most packages, adapting to it can be very simple, and yours is one of them. In this PR we simply remove the declaration from the reference version of Makevars, Makevars.win, and DESCRIPTION -- and no other changes are needed. (We also removed a spurious call for library of RcppArmadillo; there is none as the package has always been header-only so this always returned an empty string.)
Please see issues #475 and below for context, and notably #489 for this first wave of PRs. It would be terrific if you could make an upload to CRAN 'soon' to remove the reliance on C++11 which we needed in the past, but which is by now a hindrance. Please do not hesitate to reach out if I can assist in any way or clarify matters.
/cc @kurthornik