Merged
Conversation
zyrouge
requested changes
Nov 14, 2024
app/src/main/java/io/github/zyrouge/symphony/ui/components/AlbumGrid.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/github/zyrouge/symphony/ui/components/AlbumGrid.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/github/zyrouge/symphony/ui/components/ResponsiveGrid.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/github/zyrouge/symphony/ui/components/MediaSortBar.kt
Outdated
Show resolved
Hide resolved
6027a97 to
808ac17
Compare
Contributor
Author
|
What's your idea for opening the bottom sheet? Do I add a button to one of the top bars? |
Owner
The button placement is kinda awkward but should be fine. |
Contributor
Author
|
I'll use the original button minus the dropdown triangle then. |
Contributor
Author
|
The button design could use use some more effort, but this should be fully functional now. |
zyrouge
approved these changes
Nov 14, 2024
Owner
|
LGTM! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #498
Changes
Todo
Either:
Clamp widthComments
Minimum width is 100 dp, and the number of slider steps corresponds to how many of those 100-dp wide elements fit in a row. Right now, only the album view has this change, but it should be easy enough to reuse this for tabs, too. The dropdown could also hold more view options in the future, such as list / grid toggle.
So before I finish this, I'd like some feedback: Is this design good / approved?
Screenshots
Details