fix: empty path error when resolving appsLink#26
Merged
zyrouge merged 2 commits intozyrouge:mainfrom Oct 12, 2024
Merged
Conversation
Owner
|
That does not resolve path if the value is set through CLI flag. We need to wrap it in another |
Contributor
Author
I moved it into a separate if block. Should be good now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
pho initfails when symlinking is disabled,because
utils.ResolvePathalways gets called even when theappsLinkDirstring is empty.This fixes it by moving the check into the if block, where
appsLinkDirwould actually be set.I also made another change but I'm not sure if the feature should be added. I'll send a separate PR later, it's pretty late at night for me 😅