Skip to content

fix: remove init flag redefinition#21

Merged
zyrouge merged 2 commits intozyrouge:mainfrom
hashb:fix-double-apps-dir-arg
Jun 23, 2024
Merged

fix: remove init flag redefinition#21
zyrouge merged 2 commits intozyrouge:mainfrom
hashb:fix-double-apps-dir-arg

Conversation

@hashb
Copy link
Copy Markdown
Contributor

@hashb hashb commented May 20, 2024

remove redefinition of apps-desktop-dir which is currently causing panic when running pho init

$ pho init
init flag redefined: apps-desktop-dir
panic: init flag redefined: apps-desktop-dir

@zyrouge
Copy link
Copy Markdown
Owner

zyrouge commented Jun 23, 2024

Oh, did I forget about this PR? Anyway, LGTM!

@zyrouge zyrouge merged commit 85ba92a into zyrouge:main Jun 23, 2024
@parkerlreed
Copy link
Copy Markdown

Maybe this warrants a new release?

[parker@parker-framework ~]$ .local/bin/pho init
init flag redefined: apps-desktop-dir
panic: init flag redefined: apps-desktop-dir

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc0000b7b20, {0x866968, 0xc000016880}, {0xc000014800, 0x10}, {0x7d22fc, 0x18})
        /opt/hostedtoolcache/go/1.21.1/x64/src/flag/flag.go:1028 +0x3a5
github.com/urfave/cli/v3.(*FlagBase[...]).Apply(0x86cac0, 0xab7f01)
        /home/runner/go/pkg/mod/github.com/urfave/cli/v3@v3.0.0-alpha9/flag_impl.go:164 +0x807
github.com/urfave/cli/v3.newFlagSet({0x7ca40d, 0x4}, {0xc000030700, 0x8, 0x77ffc0?})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v3@v3.0.0-alpha9/flag.go:180 +0xef
github.com/urfave/cli/v3.(*Command).newFlagSet(0xab0a40)
        /home/runner/go/pkg/mod/github.com/urfave/cli/v3@v3.0.0-alpha9/command.go:679 +0x295
github.com/urfave/cli/v3.(*Command).parseFlags(0xab0a40, {0x868ab0?, 0xc000012630})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v3@v3.0.0-alpha9/command.go:735 +0xf8
github.com/urfave/cli/v3.(*Command).Run(0xab0a40, {0x868200, 0xc00009eed0}, {0xc00002fdb0, 0x1, 0x1})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v3@v3.0.0-alpha9/command.go:478 +0x6ac
github.com/urfave/cli/v3.(*Command).Run(0xc0000d4c80, {0x8681c8, 0xae6640}, {0xc000016040, 0x2, 0x2})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v3@v3.0.0-alpha9/command.go:620 +0x1685
main.main()
        /home/runner/work/pho/pho/main.go:44 +0x24e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants