Add ZYDIS_BUILD_TESTS option and include tests in CMakeLists.txt#437
Merged
athre0z merged 3 commits intozyantific:masterfrom May 20, 2023
Merged
Add ZYDIS_BUILD_TESTS option and include tests in CMakeLists.txt#437athre0z merged 3 commits intozyantific:masterfrom
athre0z merged 3 commits intozyantific:masterfrom
Conversation
Member
|
Thanks, that's good to have! I added two more commits to also rework our convenience Makefile and the CI to go via the CMake testing path for the sake of de-duplication. Edit: Ah, there appear to be issues on Windows.. let me see if I can find out what's the issue there. |
Member
|
Ok, it's also working on Windows now. I had to replace the literal |
athre0z
approved these changes
May 20, 2023
Contributor
Author
|
Thanks for the review and further improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.