Skip to content

CMake: remove CXX from project directive#418

Merged
athre0z merged 1 commit intomasterfrom
remove-cxx-cmake
Feb 19, 2023
Merged

CMake: remove CXX from project directive#418
athre0z merged 1 commit intomasterfrom
remove-cxx-cmake

Conversation

@athre0z
Copy link
Copy Markdown
Member

@athre0z athre0z commented Feb 16, 2023

Zydis currently requests a C++ compiler despite not actually using it. This breaks build on toolchains without a C++ compiler (e.g. musl libc).

@Tachi107 already did the same for zycore a while ago:

zyantific/zycore-c@8f39333

Zydis currently requests a C++ compiler despite not actually using it.
This breaks build on toolchains without a C++ compiler (e.g. musl libc).

@Tachi107 already did the same for zycore a while ago:

zyantific/zycore-c@8f39333
@athre0z athre0z added C-bug Category: This is a bug (or a fix for a bug, when applied to PRs) A-build Area: Build system labels Feb 16, 2023
@athre0z athre0z marked this pull request as ready for review February 16, 2023 15:10
@athre0z athre0z requested a review from flobernd February 16, 2023 15:10
Copy link
Copy Markdown
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@athre0z athre0z merged commit 5488b7c into master Feb 19, 2023
@athre0z athre0z deleted the remove-cxx-cmake branch February 19, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build Area: Build system C-bug Category: This is a bug (or a fix for a bug, when applied to PRs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants