Merged
Conversation
NB: The ZydisWinKernel sample still compiles for, and runs on Windows 7 x64 and higher as before. However, some adjustments were made in order for this to work, because the VS2022 WDK officially only recognises 'Windows 10 and higher' as valid target OS. 32 bit support for this sample has NOT survived this update due to new WDK restrictions.
This sample does not link when Zydis is built as a shared library, due to ZydisGetRelInfo being an internal (non-dllexported) function.
For Zydis, additionally one source file (Disassembler.c) was missing and has also been added.
3c802f7 to
8b8ae37
Compare
8b8ae37 to
c762d51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the project files under
/msvcup to date with the current v4.0 tree. Most of the changes are fairly straightforward and the commit messages should be self-explanatory for these.Quick TLDR summary of changes:
Disassemble,DisassembleSimpleandEncodeMovsamples.ZydisWinKernelfor 32 bit targets has been dropped (not my decision, but the new WDK does not leave much room for choice). If anyone for some reason really wants to build this sample for 32 bit, then this can still be done using VS2019.