add WebAssembly support#277
Merged
athre0z merged 2 commits intozyantific:masterfrom Nov 28, 2021
williballenthin:feature/wasm
Merged
add WebAssembly support#277athre0z merged 2 commits intozyantific:masterfrom williballenthin:feature/wasm
athre0z merged 2 commits intozyantific:masterfrom
williballenthin:feature/wasm
Conversation
This was referenced Nov 26, 2021
athre0z
approved these changes
Nov 28, 2021
Member
athre0z
left a comment
There was a problem hiding this comment.
LGTM, thanks again! I updated the submodule and rebased on master so we can run tests properly. Your branch was forked off a master that was 179 commits behind, presumably accidentally from an old fork.
Contributor
Author
|
Your branch was forked off a master that was 179 commits behind,
For context, I was working from the snapshot used by zydis-rs. While GH showed that the PR applied cleanly, I wasn’t sure if there were any new code/changes that need to be updated too.
Thanks for the reviews!
… On Nov 28, 2021, at 8:04 AM, Joel Höner ***@***.***> wrote:
Your branch was forked off a master that was 179 commits behind,
|
Member
|
Ah, makes sense. Thanks for the clarification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relying on the changes in zyantific/zycore-c#40, this PR adds support to Zydis for building for WebAssembly. The only updates are to implement the appropriate
ZydisStringAppend*routines when wasm is detected. Because wasm is most like a 32-bit architecture, we go the 32-bit-optimizedU32route.