Skip to content

Add regression tests for recent bugs#275

Merged
athre0z merged 1 commit intomasterfrom
add-regression-tests
Nov 22, 2021
Merged

Add regression tests for recent bugs#275
athre0z merged 1 commit intomasterfrom
add-regression-tests

Conversation

@athre0z
Copy link
Copy Markdown
Member

@athre0z athre0z commented Nov 21, 2021

No description provided.

@athre0z athre0z added C-enhancement Category: Enhancement of existing features A-decoder Area: Decoder P-medium Priority: Medium labels Nov 21, 2021
@athre0z athre0z requested a review from flobernd November 21, 2021 21:35
Copy link
Copy Markdown
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We should probably improve the regression tests to somehow have error cases as well.

In my last PR this would have been helpful to spot the invalid register that was wrongly accepted by the decoder.

@athre0z athre0z merged commit db2c163 into master Nov 22, 2021
@athre0z athre0z deleted the add-regression-tests branch November 22, 2021 10:53
@athre0z
Copy link
Copy Markdown
Member Author

athre0z commented Nov 22, 2021

Yeah, sounds sensible and shouldn't be too much work. Should probably create a separate issue for it so we don't forget.

@mappzor
Copy link
Copy Markdown
Contributor

mappzor commented Nov 22, 2021

I will add a negative case for TMM stuff in a separate PR (need to add that constraint to encoder anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-decoder Area: Decoder C-enhancement Category: Enhancement of existing features P-medium Priority: Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants