Merged
Conversation
flobernd
approved these changes
Nov 3, 2021
Member
flobernd
left a comment
There was a problem hiding this comment.
Maybe as an improvement, we could prepend the length to the actual strings (this should be easily possible as we generate the strings anyways) and remove the 'length' field from the struct. In this case a struct would not even be necessary, but probably still desired as a hint.
|
Are you guys planning to release a new crate too? https://crates.io/crates/zydis/versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables struct packing for
ZydisShortStringon Apple aarch64 platforms. For an unknown reason, compilation is now failing withldcomplaining about pointer alignment starting with macOS 12 on aarch64. On macOS 11 + aarch64, things compile perfectly fine without the change.While we have many other packed structs, the linker seems to particularly take offense with this one, as it is the only packed struct containing a pointer. I think it might be related to some form of pointer authentication.
The binary bloat from this appears to be about 40KiB.