Merged
Conversation
The PE parsing code is wildly unsafe and doesn't perform any input validation. It was originally written as an example on how to use our formatter API for using custom symbols in disassembly output. However, living in the `tools` directory incorrectly suggested to users that it's a safe tool intended for actual public use. Following a security report, we decided to just delete it for the time being, possibly bringing it back later. We intentionally never defined install rules for it (it's not installed on `make install`) and also don't ship it in the packages of any package manager repository, so the practical security impact should be low.
flobernd
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PE parsing code is wildly unsafe and doesn't perform any input validation.
It was originally written as an example on how to use our formatter API for
using custom symbols in disassembly output. However, living in the
toolsdirectory incorrectly suggested to users that it's a safe tool intended for
actual public use.
Following a security report, we decided to just delete it for the time being,
possibly bringing it back later.
We intentionally never defined install rules for it (it's not installed on
make install) and also don't ship it in the packages of any package managerrepository, so the practical security impact should be low.