Merged
Conversation
This commit makes it convenient for shell script to determine whether the login/logout process finished successfully or not. Without this, the shell would always assume that the process exits successfully (with code 0).
Owner
|
Thank you! |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CLI’s error handling by directing error messages to stderr and exiting with a non-zero code when operations fail.
- Switched
println!toeprintln!for all error outputs - Added
process::exit(1)after each error to set an exit status - Combined
std::envandstd::processimports and reorderedsrunimports
Comments suppressed due to low confidence (2)
src/main.rs:60
- [nitpick] Consider making this message more descriptive and consistent with other errors, e.g.,
eprintln!("Error parsing arguments: {}", e);.
eprintln!("parse args error: {}", e);
src/main.rs:159
- [nitpick] It would be helpful to add a test for this error path to ensure the CLI exits with a non-zero status when the config file cannot be read.
eprintln!("read config file error: {}", e);
Comment on lines
+60
to
+61
| eprintln!("parse args error: {}", e); | ||
| process::exit(1); |
There was a problem hiding this comment.
There are many duplicated eprintln! + process::exit(1) sequences; consider extracting them into a helper function like fn exit_error(msg: &str).
Suggested change
| eprintln!("parse args error: {}", e); | |
| process::exit(1); | |
| exit_error(&format!("parse args error: {}", e)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes it convenient for shell script to determine whether the login/logout process finished successfully or not. Without this, the shell would always assume that the process exits successfully (with code 0).