fix both 'detect_ip' and 'strict_bind' are true#36
Merged
zu1k merged 3 commits intozu1k:masterfrom Apr 18, 2024
Merged
Conversation
If enable both 'detect_ip' and 'strict_bind', 'get_http_client' will use detected ip, it's impossible. And if request challenge use 'online_ip' different from login use, srun will report 'expire challenge'. We need send a challenge (or better way) to get 'client_ip', and get challenge again to login.
zu1k
requested changes
Sep 16, 2023
Owner
zu1k
left a comment
There was a problem hiding this comment.
This can not compile, please fix.
Contributor
Author
|
Sorry for this, i will fix it later. Our school network is under maintenance |
Owner
|
Hi @InkerBot , are you still here? |
Owner
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If enable both 'detect_ip' and 'strict_bind', 'get_http_client' will use detected ip, it's impossible.
If request challenge use 'online_ip' different from login use, srun will report 'expire challenge'.
We need send a challenge (or better way) to get 'client_ip', and get challenge again to login.