Conversation
🤖 Augment PR SummarySummary: Adjusts 🤖 Was this summary useful? React with 👍 or 👎 |
| if [ -n "${invalidlist}" ]; then | ||
| printSoftError "The following requested port(s) do not exist:\n\t$(echo "${invalidlist}" | tr -s '[:space:]')" | ||
| printError "Check port name(s), remove any port suffixes and retry command." | ||
| printSoftError "Check port name(s), remove any port suffixes and retry command." |
There was a problem hiding this comment.
bin/zopen-install:+869: Changing this from printError to printSoftError means the script can now continue (and potentially exit 0) even when invalid ports were requested; that seems inconsistent with the message telling the user to retry and could mask failures for callers that check the exit status.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| fi | ||
|
|
||
| for item in ${invalidlist}; do | ||
| if [[ "$(echo $item)" == "$(echo $chosenRepo)" ]]; then |
There was a problem hiding this comment.
bin/zopen-install:+873: chosenRepo here is the last value from the earlier loop, so this exit 1 becomes order-dependent (e.g., aborts if an invalid repo happens to be last, but may succeed if the same invalid repo is earlier). This can also abort even when installArray has valid ports queued, which looks like unintended behavior.
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: sabi789 <sabithac6298@gmail.com>
7c54843 to
bcbfadc
Compare
What type of PR is this? (check all applicable)
Category
Description
Fixes zopen upgrade exit issue
Adjusts zopen-install handling of invalid port/repo names.