Skip to content

Fix cicd script to run on-nightly script + General fixes#1151

Merged
sachintu47 merged 4 commits intomainfrom
generalfixes
Mar 20, 2026
Merged

Fix cicd script to run on-nightly script + General fixes#1151
sachintu47 merged 4 commits intomainfrom
generalfixes

Conversation

@sachintu47
Copy link
Copy Markdown
Member

@sachintu47 sachintu47 commented Mar 20, 2026 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Content Update

Category

  • zopen build framework
  • zopen package manager
  • Documentation
  • CI/CD
  • Tools

Description

  1. cicd: disable CVE JSON and remove duplicate newly-released doc generation
  2. Pass CFLAGS, LFLAGS, LIBS only for C/C++ compiler

Related Issues

  • Related Issue #
  • Closes #

[optional] Are there any post-deployment tasks or follow-up actions required?

@sachintu47
Copy link
Copy Markdown
Member Author

sachintu47 commented Mar 20, 2026

augment review

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 20, 2026 •
edited
Loading

🤖 Augment PR Summary

Summary: This PR updates the zopen build framework and nightly docs generation scripts to reduce incorrect/duplicate behavior and tighten compiler flag propagation.

Changes:

  • bin/zopen-build: adds meta as an implicit runtime dependency (temporary, until zopen-install handles it).
  • bin/zopen-build: limits the git apply --3way retry path to GIT-based sources and retains shallow-repo unshallowing for that case.
  • bin/zopen-build: centralizes toolchain/flag passing into reusable “extra opts” variables and only injects them when CC is set.
  • cicd/on_nightly.sh: disables nightly CVE JSON generation and removes duplicate newly-released doc generation.

Technical Notes: The build command strings are still executed via eval (via runAndLog), so the main behavioral change is when/where compiler/linker variables are injected into those command strings.

🤖 Was this summary useful? React with 👍 or 👎

augmentcode[bot]
augmentcode bot reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@sachintu47 sachintu47 marked this pull request as ready for review March 20, 2026 11:38
@sachintu47 sachintu47 changed the title Generalfixes Fix cicd script to run on-nightly script + General fixes Mar 20, 2026
augmentcode[bot]
augmentcode bot reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@sachintu47 sachintu47 merged commit a104131 into main Mar 20, 2026
1 of 2 checks passed
@sachintu47 sachintu47 deleted the generalfixes branch March 20, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HarithaIBM HarithaIBM HarithaIBM approved these changes

@IgorTodorovskiIBM IgorTodorovskiIBM Awaiting requested review from IgorTodorovskiIBM IgorTodorovskiIBM is a code owner

@MikeFultonDev MikeFultonDev Awaiting requested review from MikeFultonDev MikeFultonDev is a code owner

@DevonianTeuchter DevonianTeuchter Awaiting requested review from DevonianTeuchter DevonianTeuchter is a code owner

@v1gnesh v1gnesh Awaiting requested review from v1gnesh v1gnesh is a code owner

+1 more reviewer

@augmentcode augmentcode[bot] augmentcode[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sachintu47 @HarithaIBM