Skip to content

Add download retry mechanism#1144

Merged
sachintu47 merged 4 commits intomainfrom
downloadRetry
Feb 23, 2026
Merged

Add download retry mechanism#1144
sachintu47 merged 4 commits intomainfrom
downloadRetry

Conversation

@sachintu47
Copy link
Copy Markdown
Member

@sachintu47 sachintu47 commented Feb 19, 2026 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Content Update

Category

  • zopen build framework
  • zopen package manager
  • Documentation
  • CI/CD
  • Tools

Description

See Augement PR summary #1144 (comment)

Related Issues

  • Related Issue #
  • Closes #

[optional] Are there any post-deployment tasks or follow-up actions required?

@sachintu47
Copy link
Copy Markdown
Member Author

sachintu47 commented Feb 19, 2026

augment review

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Feb 19, 2026 •
edited
Loading

🤖 Augment PR Summary

Summary: This PR improves tarball download robustness in bin/zopen-build by introducing a retrying curl wrapper and basic post-download validation.

Changes:

  • Adds attemptDownload (curl with redirects, retries, timeouts, and HTTP-fail behavior) and validateDownload (size check + HTML error-page detection).
  • Updates downloadTarBall to try the primary URL and an optional mirror URL, stopping on the first successful validated download.
  • Removes the prior “warm-up” header-only curl request and relies on curl retry behavior instead.
  • Refactors dependency assembly in checkEnv into implicitDeps (download/extract tools) vs langDeps (compiler checks + optional zoslib/ccache).
  • Adjusts --get-source behavior to only install implicit download/extract dependencies.
  • Introduces ZOPEN_VENDORD and sets ZOPEN_VENDOR in setEnv, removing the ad-hoc defaulting in generateZOSLIBHooks.

Technical Notes: Validation aims to catch common “download succeeded but content is an error page” cases before extraction/patching proceeds.

🤖 Was this summary useful? React with 👍 or 👎

augmentcode[bot]
augmentcode bot reviewed Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@sachintu47
Copy link
Copy Markdown
Member Author

sachintu47 commented Feb 20, 2026

augment review

augmentcode[bot]
augmentcode bot reviewed Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@sachintu47
Copy link
Copy Markdown
Member Author

sachintu47 commented Feb 23, 2026

augment review

augmentcode[bot]
augmentcode bot reviewed Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 4 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@sachintu47
Copy link
Copy Markdown
Member Author

sachintu47 commented Feb 23, 2026

augment review

@sachintu47 sachintu47 changed the title Download retry Add download retry mechanism Feb 23, 2026
augmentcode[bot]
augmentcode bot reviewed Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@sachintu47 sachintu47 marked this pull request as ready for review February 23, 2026 15:16
augmentcode[bot]
augmentcode bot reviewed Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

IgorTodorovskiIBM
IgorTodorovskiIBM approved these changes Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@IgorTodorovskiIBM IgorTodorovskiIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wonder if we should have a mirror capability like in brew:
https://github.com/Homebrew/homebrew-core/blob/f7be98ed3187412b517582b097c8c7bbfe080c79/Formula/g/gmp.rb#L5-L6 (as a future item)

@sachintu47 sachintu47 merged commit eeaae2f into main Feb 23, 2026
1 of 2 checks passed
@sachintu47 sachintu47 deleted the downloadRetry branch February 23, 2026 15:23
@v1gnesh
Copy link
Copy Markdown
Collaborator

v1gnesh commented Feb 24, 2026

Than you @sachintu47, glad you're finding Augment's suggestions useful/relevant.
Totally get that it can feel nitpick-y when a bot comes along to say fix this this etc., especially when we have to go and fix it up lol.

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member

IgorTodorovskiIBM commented Feb 24, 2026

Than you @sachintu47, glad you're finding Augment's suggestions useful/relevant. Totally get that it can feel nitpick-y when a bot comes along to say fix this this etc., especially when we have to go and fix it up lol.

Thanks @v1gnesh for getting us the access!

@sachintu47
Copy link
Copy Markdown
Member Author

sachintu47 commented Feb 24, 2026

Than you @sachintu47, glad you're finding Augment's suggestions useful/relevant. Totally get that it can feel nitpick-y when a bot comes along to say fix this this etc., especially when we have to go and fix it up lol.

It really helped. Thanks for suggesting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IgorTodorovskiIBM IgorTodorovskiIBM IgorTodorovskiIBM approved these changes

@MikeFultonDev MikeFultonDev Awaiting requested review from MikeFultonDev MikeFultonDev is a code owner

@DevonianTeuchter DevonianTeuchter Awaiting requested review from DevonianTeuchter DevonianTeuchter is a code owner

@HarithaIBM HarithaIBM Awaiting requested review from HarithaIBM HarithaIBM is a code owner

@v1gnesh v1gnesh Awaiting requested review from v1gnesh v1gnesh is a code owner

+1 more reviewer

@augmentcode augmentcode[bot] augmentcode[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sachintu47 @v1gnesh @IgorTodorovskiIBM