Ignore __annotate_func__ added in Python 3.14b1#351
Merged
icemac merged 1 commit intozopefoundation:masterfrom Jan 9, 2026
Merged
Ignore __annotate_func__ added in Python 3.14b1#351icemac merged 1 commit intozopefoundation:masterfrom
__annotate_func__ added in Python 3.14b1#351icemac merged 1 commit intozopefoundation:masterfrom
Conversation
Following python/cpython#132345, type annotations result in the annotate function being stored at `__annotate_func`. This caused test failures in klein along the lines of: ``` zope.interface.exceptions.BrokenMethodImplementation: The object FrozenHTTPHeaders(rawHeaders=()) has failed to implement interface klein._imessage.IHTTPHeaders: The contract of klein._imessage.IHTTPHeaders.__annotate_func__(format) is violated because 'FrozenHTTPHeaders.__annotate__()' doesn't allow enough arguments. ``` Ignore this new internal name.
icemac
approved these changes
Jan 9, 2026
Member
icemac
left a comment
There was a problem hiding this comment.
Thank you for fixing this issue.
Member
|
Just released in https://pypi.org/project/zope.interface/8.2/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following python/cpython#132345, type annotations result in the annotate function being stored at
__annotate_func. This caused test failures in klein along the lines of:Ignore this new internal name.