Skip to content

Add support for python 3.14, drop support for 3.9#247

Merged
icemac merged 4 commits intomasterfrom
config-with-pure-python-template-f6df9072
Jan 28, 2026
Merged

Add support for python 3.14, drop support for 3.9#247
icemac merged 4 commits intomasterfrom
config-with-pure-python-template-f6df9072

Conversation

@perrinjerome
Copy link
Contributor

  • I signed and returned the Zope Contributor Agreement, and received and accepted an invitation to join a team in the zopefoundation GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Developer guidelines.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

@perrinjerome perrinjerome requested a review from icemac January 27, 2026 12:49
@coveralls
Copy link

coveralls commented Jan 27, 2026

Pull Request Test Coverage Report for Build 21426341249

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 73.245%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ZEO/_forker.py 5 6 83.33%
Totals Coverage Status
Change from base Build 20894885810: 0.02%
Covered Lines: 7782
Relevant Lines: 10107

💛 - Coveralls

Co-authored-by: Jens Vagelpohl <jens@plyp.com>
@perrinjerome
Copy link
Contributor Author

perrinjerome commented Jan 27, 2026

Oh test fail on 3.14 on github actions ... I don't see what can be the problem and I don't have much time available these days, so I don't think I can continue working on this.

edit: ah it might just be https://stackoverflow.com/questions/79785458/why-does-multiprocess-with-fork-fail-under-python-3-14-but-work-in-3-13-works

@perrinjerome perrinjerome marked this pull request as draft January 27, 2026 13:11
@dataflake dataflake marked this pull request as ready for review January 27, 2026 14:31
On python3.14, the default method is "forkserver" and test suite showed
errors starting ZEO server using this method.
@perrinjerome perrinjerome force-pushed the config-with-pure-python-template-f6df9072 branch from 0c11f1b to c5db605 Compare January 28, 2026 05:29
@perrinjerome perrinjerome changed the title Config with pure python template f6df9072 Add support for python 3.14, drop support for 3.9 Jan 28, 2026
@perrinjerome
Copy link
Contributor Author

@dataflake I amended the commit changing the multiprocess start method so that it affects only the local usage and not the global state, this seems good enough now. I'm re-requesting a review, as this is a significant change. If that's OK I'm going to "Squash and merge".

I have not investigated at all why forkserver does not work with the test suite.

@icemac icemac merged commit 615b50e into master Jan 28, 2026
26 checks passed
@icemac icemac deleted the config-with-pure-python-template-f6df9072 branch January 28, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants