Implementation of Basic04#892
Merged
vlevigneron merged 4 commits intoMay 6, 2021
Merged
Conversation
matsduf
requested changes
Apr 30, 2021
Contributor
|
I suggest that translation is done outside this PR. |
matsduf
reviewed
Apr 30, 2021
- Change basic methods execution order
matsduf
approved these changes
May 6, 2021
Closed
Contributor
Release testing for v2021.1Works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #763
Need to be done:
=> Unit tests
=> translation of new messages
Updated 2021-05-17:
How to test this PR
Inspect the test case specification for BASIC04. Find test zones and verify that the implementation captures the issues and non-issues.