Fixed riswhois (RIPE) support#834
Conversation
ghost
left a comment
There was a problem hiding this comment.
Maybe there should be an automated test to check that everything works fine with the RIPE profile.
| my $socket; | ||
| unless( $socket = IO::Socket::INET->new( PeerAddr => $db_source->name->string, | ||
| PeerPort => q{43}, | ||
| Proto => q{tcp} ) | ||
| ) { |
There was a problem hiding this comment.
There's way too much going on here. It would be more readable with my $socket = ...; if ( !$socket ) { ... }.
There was a problem hiding this comment.
Same, same, but I changed the code as you suggested.
One complexity is that you do not want automated tests that are dependent on remote connection. We have built-in solution for canned DNS queries, but this something different. But it is a good suggestion. I'll create an issue (#835). |
|
@vlevigneron, could you review after my change? |
Resolves issue #833