Skip to content

CI: install ExtUtils::PkgConfig as prerequisite#1398

Merged
marc-vanderwal merged 1 commit into
zonemaster:developfrom
marc-vanderwal:bugfix/missing-extutils-pkgconfig-in-ci
Nov 25, 2024
Merged

CI: install ExtUtils::PkgConfig as prerequisite#1398
marc-vanderwal merged 1 commit into
zonemaster:developfrom
marc-vanderwal:bugfix/missing-extutils-pkgconfig-in-ci

Conversation

@marc-vanderwal

Copy link
Copy Markdown
Contributor

Purpose

This PR restores CI to working order, after a new build dependency was introduced in Zonemaster::LDNS.

Context

See zonemaster/zonemaster-ldns#210.

Changes

Install ExtUtils::PkgConfig during CI, before attempting to install Zonemaster::LDNS.

How to test this PR

N/A.

@marc-vanderwal marc-vanderwal added T-Bug Type: Bug in software or error in test case description P-High Priority: Issue to be solved before other V-Patch Versioning: The change gives an update of patch in version. labels Nov 21, 2024
@marc-vanderwal marc-vanderwal added this to the v2024.2 milestone Nov 21, 2024
@marc-vanderwal marc-vanderwal force-pushed the bugfix/missing-extutils-pkgconfig-in-ci branch 2 times, most recently from 2642726 to 2208e43 Compare November 21, 2024 13:42
Pull request zonemaster/zonemaster-ldns#210
added an additional build-time dependency on ExtUtils::PkgConfig that
wasn’t mirrored in the CI configuration for Zonemaster::Engine,
therefore breaking CI. Adding the missing dependency should restore CI
to normal working state.
@marc-vanderwal marc-vanderwal force-pushed the bugfix/missing-extutils-pkgconfig-in-ci branch from 2208e43 to e9060d1 Compare November 21, 2024 13:44
@marc-vanderwal marc-vanderwal marked this pull request as ready for review November 21, 2024 13:48
@matsduf

matsduf commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

@marc-vanderwal, please merge.

@marc-vanderwal marc-vanderwal merged commit 67ec9b1 into zonemaster:develop Nov 25, 2024
@marc-vanderwal marc-vanderwal deleted the bugfix/missing-extutils-pkgconfig-in-ci branch January 29, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P-High Priority: Issue to be solved before other T-Bug Type: Bug in software or error in test case description V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants