Redefines batch_status to replace get_batch_job_result#1215
Merged
Conversation
* Makes API get_batch_job_result documented as deprecated. See PR zonemaster/zonemaster#1304 * Redefines API batch_status. See the same PR. zmb() is updated to be able to use the updated batch_status().
marc-vanderwal
left a comment
Contributor
There was a problem hiding this comment.
Looks OK. Some minor suggestions.
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
marc-vanderwal
previously approved these changes
May 20, 2025
Contributor
Author
|
@mattias-p, you approved zonemaster/zonemaster#1304 (the specification). Can you please review/approve the PR (the implementation) too? |
mattias-p
reviewed
Jun 2, 2025
mattias-p
left a comment
Member
There was a problem hiding this comment.
Looks good overall. I have some comments.
Co-authored-by: Mattias Päivärinta <mattias@paivarinta.se>
mattias-p
reviewed
Jun 3, 2025
Contributor
Author
|
@mattias-p and @marc-vanderwal, could you review? |
* Adds documentation on "no-" prefixed options. * Creates and uses a new function for conversion into JSON boolean.
Contributor
Author
|
@mattias-p, I have reverted the change of the |
marc-vanderwal
previously approved these changes
Jun 5, 2025
Contributor
Author
|
@marc-vanderwal, based on feedback from @mattias-p I changed the options for the new method. Can you rereview? @mattias-p, please rereview. |
marc-vanderwal
previously approved these changes
Jun 5, 2025
mattias-p
reviewed
Jun 10, 2025
mattias-p
left a comment
Member
There was a problem hiding this comment.
I have some comments about tightening up things, but otherwise this looks good.
Co-authored-by: Mattias Päivärinta <mattias@paivarinta.se>
mattias-p
approved these changes
Jun 10, 2025
MichaelTimbert
approved these changes
Jun 11, 2025
MichaelTimbert
left a comment
Contributor
There was a problem hiding this comment.
Tested and working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR implements the RPCAPI update in zonemaster/zonemaster/pull/1304.
Changes
batch_statuswas defined as an alias toget_batch_job_result. Now it redefined to be a smarter replacement of the old API.How to test this PR
Prepare a small batch (10-15 domain names) in a text file. Set down
number_of_processes_for_frontend_testingandnumber_of_processes_for_batch_testingto a low value (e.g. 2). Start the batch withzmband read the batch status withzmb. Read the status with various values of the optional options.