Adapt to changed Engine API#1143
Merged
Merged
Conversation
Contributor
|
This PR fails. Is that because it depends on zonemaster/zonemaster-engine#1316 being merged? |
Contributor
|
There are no reviewers to this PR. |
Member
Author
|
CI fails because it depends on zonemaster/zonemaster-engine#1316. I haven't found a good way to run CI against a different Engine branch. |
marc-vanderwal
previously approved these changes
Jun 2, 2025
Member
Author
|
I added a forgotten import. Please review again. |
marc-vanderwal
approved these changes
Jun 3, 2025
tgreenx
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adapts Backend to the API change in zonemaster/zonemaster-engine#1316.
Context
Should be merged together with zonemaster/zonemaster-engine#1316.
Changes
trim_space() is now invoked before normalize_name(). Prior to zonemaster/zonemaster-engine#1316 normalize_name() handled the space trimming itself.
How to test this PR
You should still be able to include surrounding space in domain name parameters to RPCAPI calls.