Adds unit test for MANIFEST#1137
Closed
matsduf wants to merge 2 commits into
Closed
Conversation
ae1b136 to
cef0f49
Compare
mattias-p
reviewed
Nov 24, 2023
mattias-p
left a comment
Member
There was a problem hiding this comment.
The changes in .travis.yml doesn't look right, but otherwise this looks good to me.
Contributor
Author
@mattias-p: No, the changes are to try to find out why the MO files are not created. I cannot see them, and the An alternative is |
cef0f49 to
5bfcea3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds unit test that will capture missing updates for MANIFEST. Copied from Zonemaster-Engine.
How to test this PR
Verify that is reports when MANIFEST is not updated and not when it is.