RPCAPI apply new methods in code, scripts and tests#1083
Merged
7 commits merged intoMar 9, 2023
Merged
Conversation
Contributor
|
Is this a "V-Minor" or "V-Major"? I guess it depends on if |
Author
I'd say "V-Minor". zmb explicitly states: So I don't think it's part of the API yet. |
matsduf
requested changes
Feb 27, 2023
Contributor
That is true. It is time to make the interface of zmb stable (in a different PR). |
added 6 commits
February 27, 2023 17:44
Artefact from commit 427ec00
`RPCAPI.enable_add_api_user` and `RPCAPI.enable_add_batch_job` * remove properties from confi INI file * emit warning if the property is set in the INI file
2 tasks
matsduf
requested changes
Feb 27, 2023
matsduf
approved these changes
Mar 6, 2023
matsduf
left a comment
Contributor
There was a problem hiding this comment.
This should be fine now.
Member
|
I've tested this and found the problems also reported in #1105. With the changes in #1109 this works as advertised. I also created zonemaster/zonemaster#1159 based on what I learned testing this. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Second stage in the update of the RPCAPI methods. This PR updates the code and tests to use the new methods from #1054.
Context
Follow up #1054
Changes
How to test this PR
Unit tests should pass.