More links#584
Conversation
matsduf
left a comment
There was a problem hiding this comment.
Github seems to render URLs with or withoud surrounding "<...>". Most of your proposed changes are just adding "<...>". Why do you want to do that?
If we add them here, I think we should do it consistently and having it documented in the "Style Guide".
I select "Request changes" but no necessary to your proposal, but rather to the description of this PR and a reply to this.
|
The purpose is to increase the range of automatic link checking to include autolinks. Standard Commonmark parser libraries are able to extract standard autolinks but not GFM autolinks. Those libraries are used by link checking tools. I occasionally use tools to look for broken links. That's how I found the broken links in #518. Unfortunately the tool I used didn't know about the GFM autolink extension, so there were lots of links that didn't get checked that time around. Among them the two links to http://www.zonecheck.fr/features.shtml that are fixed in this PR. To mitigate the problem of overlooked links in the future I searched for GFM autolinks in zonemaster and added angle brackets to all the links I could find. I agree that an item about this should be added to the style guide. |
|
I want to see a more complete proposal of how links should be written Zonemaster documentation before this PR is merged. When I test, putting "<...>" around a link does not add anything. It does not change the parsing. |
|
This is not about presentation on Github. Github renders Commonmark autolinks and GFM autolinks identically. I suggest autolinks are entered like this: http://spec.commonmark.org/0.28/#autolinks |
|
According to http://spec.commonmark.org/0.28/#autolinks the following three should result in autolinks but only the first does in Github:
Am I doing something wrong? |
|
Looks like you've discovered two Github bugs. They're autolinks according to GFM as well: And for reference: https://github.github.com/gfm/#what-is-github-flavored-markdown- |
|
Except for the confusion of the links <..>, i am ok with the content |
matsduf
left a comment
There was a problem hiding this comment.
There is no harm to have the "<...>" in the already explicit URLs.
|
@mattias-p then pls. merge |
|
@mattias-p please close |
|
@sandoche2k This is already merged. |
More link fixing. Using standard autolinks simplifies automatic link checking.