Deprecate yes/no boolean values#1438
Merged
Merged
Conversation
matsduf
reviewed
Nov 6, 2025
tgreenx
approved these changes
Nov 6, 2025
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
LGTM. But this should be implemented before merged.
Contributor
matsduf
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR deprecates boolean literals other than
trueandfalsein the config file.Context
This harmonizes boolean representation with the RPC API.
Changes
These changes affect the
RPCAPI.enable_add_batch_jobandRPCAPI.enable_add_api_userconfig properties.How to test this PR
N/A