Updates DNSSEC07 test case specification by matsduf · Pull Request #1425 · zonemaster/zonemaster

matsduf · 2025-09-12T21:13:01Z

Purpose

This PR updates the specification of DNSSEC07 in several ways:

It updates the specification to modern standards.
It raises absence of DNSSEC signing to WARNING.
It raises absence of DS to WARNING if the zone is signed.

Currently in the implementation, DNSSEC07 is run first, and if DNSSEC07 outputs NOT_SIGNED then no other test case in DNSSEC module is run.

After this update, DNSSEC07 should still be run first, and then DNSSEC11. If updated DNSSEC07 outputs DS07_NOT_SIGNED then no other test cases, besides DNSSEC11, in DNSSEC module should be run.

For the future, I think all test cases should be run for every test. For that all DNSSEC test cases should be updated to output a good INFO message for unsigned zones. All other test cases should be updated to always output an INFO message if no other message is outputted. In that way all tests will show the same number of test cases. (Except if the test breaks in Basic because it cannot be run.)

With the update, DNSSEC07 will always output one of the following messages (besides possibly other messages):

DS07_NOT_SIGNED
DS07_SIGNED
DS07_INCONSISTENT_SIGNED

Test scenarios are available by #1432.

How to test this PR

Review.

Adds text that DNSSEC07 is special and should be run first in the DNSSEC module. The output of the test case governs if any other DNSSEC test cases should be run, except DNSSEC11 that should always be run second in the DNSSEC module.

matsduf · 2025-10-08T16:09:28Z

@peterthomassen, please review this PR. For the test scenarios for the test case, see #1432, and in that see docs/public/specifications/test-zones/DNSSEC-TP/dnssec07.md for the specification of the test scenarios (and test zones).

peterthomassen

thank you for working on this!

matsduf

@peterthomassen, thank you for the review. I have updated the text based on your comments.

tgreenx · 2025-10-30T14:27:26Z

Implementation in zonemaster/zonemaster-engine#1476.

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

marc-vanderwal

The test procedure looks good to me. I have some comments and suggestions though.

Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>

marc-vanderwal

Two more little typos, including I didn’t see last time. Sorry!

Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

matsduf · 2025-11-07T08:09:51Z

@marc-vanderwal, please re-review.

Updated to modern standard

7733fb2

matsduf requested review from MichaelTimbert, marc-vanderwal, mattias-p, tgreenx and tolvmannen September 12, 2025 21:13

matsduf added A-TestCase Area: Test case specification or implementation of test case A-Documentation Area: Documentation only. RC-Features Release category: Features. labels Sep 12, 2025

matsduf added 2 commits September 16, 2025 13:43

Updates specification

3a7cf57

Adds text that DNSSEC07 is special and should be run first in the DNSSEC module. The output of the test case governs if any other DNSSEC test cases should be run, except DNSSEC11 that should always be run second in the DNSSEC module.

Adjusted levels on two messages

b08f024

matsduf mentioned this pull request Oct 3, 2025

Adds test scenarios for updated DNSSEC07 #1432

Merged

tgreenx linked an issue Oct 9, 2025 that may be closed by this pull request

Update DNSSEC07 test case to explicitly check for DNSSEC #1423

Closed

peterthomassen reviewed Oct 9, 2025

View reviewed changes

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

Updates based on review comments from @peterthomassen

0c145d1

matsduf commented Oct 20, 2025

View reviewed changes

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

tgreenx added this to the v2025.2 milestone Oct 28, 2025

tgreenx reviewed Oct 30, 2025

View reviewed changes

tgreenx mentioned this pull request Oct 30, 2025

Update DNSSEC07 implementation zonemaster/zonemaster-engine#1476

Merged

matsduf and others added 9 commits October 30, 2025 17:08

Apply suggestion from @tgreenx

3b29dd1

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Apply suggestion from @tgreenx

6153fff

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Apply suggestion from @tgreenx

b4e17a7

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Apply suggestion from @tgreenx

4140658

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Apply suggestion from @tgreenx

d24292d

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Apply suggestion from @tgreenx

4fd6be5

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Apply suggestion from @tgreenx

1c65845

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Apply suggestion from @tgreenx

bb34242

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Apply suggestion from @tgreenx

5d331b4

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

matsduf and others added 3 commits October 30, 2025 17:43

Apply suggestion from @tgreenx

cac4b5c

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Apply suggestion from @tgreenx

9c6a2db

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Editorial updates (clarifications).

ebe354a

matsduf requested a review from tgreenx November 2, 2025 16:08

marc-vanderwal reviewed Nov 3, 2025

View reviewed changes

matsduf and others added 3 commits November 3, 2025 17:14

Update docs/public/specifications/tests/DNSSEC-TP/dnssec07.md

515711f

Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>

Update docs/public/specifications/tests/DNSSEC-TP/dnssec07.md

4bd95ef

Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>

Clarifications

1369585

matsduf force-pushed the update-dnssec07-test-case-spec branch from be7797b to 1369585 Compare November 3, 2025 19:30

matsduf requested a review from marc-vanderwal November 3, 2025 19:34

marc-vanderwal reviewed Nov 4, 2025

View reviewed changes

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

tgreenx reviewed Nov 4, 2025

View reviewed changes

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

tgreenx reviewed Nov 4, 2025

View reviewed changes

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

tgreenx reviewed Nov 4, 2025

View reviewed changes

Comment thread docs/public/specifications/tests/DNSSEC-TP/dnssec07.md Outdated

matsduf and others added 5 commits November 4, 2025 11:39

Update docs/public/specifications/tests/DNSSEC-TP/dnssec07.md

e9cbbef

Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>

Update docs/public/specifications/tests/DNSSEC-TP/dnssec07.md

aa8bdcf

Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>

Update docs/public/specifications/tests/DNSSEC-TP/dnssec07.md

3fdbb77

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Update docs/public/specifications/tests/DNSSEC-TP/dnssec07.md

bc188ec

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Update docs/public/specifications/tests/DNSSEC-TP/dnssec07.md

ad571fc

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

marc-vanderwal previously approved these changes Nov 4, 2025

View reviewed changes

Corrections after adding support for names of parent name servers

3199444

matsduf dismissed marc-vanderwal’s stale review via 3199444 November 4, 2025 13:54

matsduf requested review from marc-vanderwal and tgreenx November 4, 2025 13:54

tgreenx approved these changes Nov 6, 2025

View reviewed changes

matsduf merged commit a707c37 into zonemaster:develop Nov 13, 2025

matsduf deleted the update-dnssec07-test-case-spec branch November 13, 2025 16:23

tgreenx mentioned this pull request Dec 9, 2025

Update DNSSEC07 message IDs #1449

Merged

matsduf mentioned this pull request Jan 20, 2026

Update DNSSEC07 test case to explicitly check for DNSSEC #1423

Closed

Uh oh!

Conversation

matsduf commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

How to test this PR

Uh oh!

matsduf commented Oct 8, 2025

Uh oh!

peterthomassen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matsduf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgreenx commented Oct 30, 2025

Uh oh!

marc-vanderwal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marc-vanderwal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matsduf commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

matsduf commented Sep 12, 2025 •

edited

Loading