Add test scenario specification for Zone11#1417
Merged
marc-vanderwal merged 4 commits intoNov 14, 2025
Merged
Conversation
matsduf
previously requested changes
Aug 11, 2025
matsduf
left a comment
Contributor
There was a problem hiding this comment.
The test zones are not included.
Contributor
Author
Yes, they’re coming, but I wanted some early feedback on the outline of the test scenarios before completing them. |
34a9b4a to
b3a3162
Compare
Looks fine now. Waiting for the configuration of the test case to be completed.
b3a3162 to
0f3b089
Compare
Contributor
Author
|
Test zones complete (and tested manually); the only thing I’m missing now is the |
matsduf
reviewed
Nov 5, 2025
0f3b089 to
53ecb49
Compare
Contributor
Author
|
Everything complete. I noticed however a mistake in the |
matsduf
reviewed
Nov 5, 2025
Comment on lines
+48
to
+51
| $ORIGIN zone11.arpa. | ||
| @ NS ns1.zone11.xa. | ||
| @ NS ns2.zone11.xa. | ||
|
|
Contributor
There was a problem hiding this comment.
This is one way to do it. I have moved to creating test case dedicated root, xa and other zones instead to have as few shared files as possible to cut down the risk of conflicts
matsduf
reviewed
Nov 5, 2025
matsduf
left a comment
Contributor
There was a problem hiding this comment.
Looks fine. The final test is when used as unit tests.
Comment on lines
+21
to
+23
| ;; Local Variables: | ||
| ;; mode: dns | ||
| ;; End: |
Contributor
Author
There was a problem hiding this comment.
Yes, this is to switch to dns-mode instead of fundamental-mode when visiting the file in Emacs.
tgreenx
reviewed
Nov 6, 2025
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
A few minor comments otherwise LGTM
Contributor
There was a problem hiding this comment.
(File to be updated before merging)
The overhaul of the test specification for Zone11 (see zonemaster#1415) is a good opportunity to add some test scenarios for that same test case. Of note here are the scenarios that perform tests on three different root zones. They will require three changes to the root hints during unit testing.
matsduf
reviewed
Nov 6, 2025
Add the test zones and the CoreDNS configuration files implementing the test scenario specification for Zone11.
The parent (root zone) delegates arpa. to ns1. and ns2., but the NS records at the apex of the arpa. zone listed different name servers: ns1.xa and ns2.xa. This inconsistency caused some odd errors when trying to run zonemaster-cli on those test zones, while preparing the test-zones-output.md. This might be the sign of a bug somewhere in Basic02, which should warrant further investigation.
Add the output for test scenarios.
53ecb49 to
c355f40
Compare
tgreenx
approved these changes
Nov 6, 2025
matsduf
approved these changes
Nov 13, 2025
Contributor
|
@marc-vanderwal, please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a test scenario specification for Zone11 that matches the test case specification as worded in #1415.
Of note here are the scenarios that perform tests on three different root zones. They will require three changes to the root hints during unit testing.
Context
See #1256 (issue about Zone11).
Depends on #1415 (Zone11 test case specification update).
Changes
How to test this PR
Review.