Updates Changes for v2025.1 release#1393
Merged
Merged
Conversation
f429de9 to
ec73964
Compare
tgreenx
reviewed
Jun 26, 2025
|
|
||
| [Deprecations] | ||
| - API method "get_batch_job_result" is deprecated to be removed in v2025.2. | ||
| Use method "batch_status" instead. See #1304 and Zonemaster-Backend |
Contributor
There was a problem hiding this comment.
Suggested change
| Use method "batch_status" instead. See #1304 and Zonemaster-Backend | |
| Use method "batch_status" instead. See #1304 and Zonemaster-Backend. |
Comment on lines
+26
to
+27
| - Defines Backend API "batch_status" to replace "get_batch_job_result" (#1304). | ||
| For implementation see Zonemaster-Backend. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Defines Backend API "batch_status" to replace "get_batch_job_result" (#1304). | |
| For implementation see Zonemaster-Backend. | |
| - Stabilizes Backend API "batch_status" to replace "get_batch_job_result". | |
| See #1304 and Zonemaster-Backend. |
Contributor
Author
There was a problem hiding this comment.
No, why remove information? "Stabilizes" says less than "defines". What is the problem with original text?
Contributor
There was a problem hiding this comment.
The method already exists (defined), it was just experimental, and now we stabilize it. But it's also fine as is, I don't mind.
Contributor
Author
There was a problem hiding this comment.
Yes, it is "defined to replace" which works in both situations. From a user point of view it is a new API method.
| - Adds Slovenian translation ([#1333]). Also see [Zonemaster-Engine], [Zonemaster-CLI], [Zonemaster-Backend] and [Zonemaster-GUI]. | ||
| - Lowers all WARNING to NOTICE in test case Zone01. Lowers ERROR to WARNING in test case DNSSEC03. See [Zonemaster-Engine], [#1384] and [#1352]. | ||
| - Updates "Requirements and normalization of domain names in input" to make removal of leading and trailing space optional ([#1260]). | ||
| - Defines Backend API "batch\_status" to replace "get\_batch\_job\_result" ([#1304]). For implementation see [Zonemaster-Backend]. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Defines Backend API "batch\_status" to replace "get\_batch\_job\_result" ([#1304]). For implementation see [Zonemaster-Backend]. | |
| - Stabilizes Backend API "batch\_status" to replace "get\_batch\_job\_result". See [#1304] and [Zonemaster-Backend]. |
tgreenx
reviewed
Jun 26, 2025
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
approved these changes
Jun 26, 2025
Contributor
Author
|
This must be merged to release. I assume that one approval is enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is a preparation for v2025.1 release.
Changes
RELEASE.md will also be used for the Github release page.
How to test this PR
Review.