Skip to content

Editorial update of installation instruction#1391

Merged
matsduf merged 3 commits into
zonemaster:developfrom
matsduf:update-backend-installation-instructions
Jun 24, 2025
Merged

Editorial update of installation instruction#1391
matsduf merged 3 commits into
zonemaster:developfrom
matsduf:update-backend-installation-instructions

Conversation

@matsduf

@matsduf matsduf commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose

  1. This PR removes unneeded text for FreeBSD installation to make it easier to read. The command never tries to install the DB libraries. It did years ago.
  2. Updates information on PostgreSQL version for FreeBSD.
  3. Removes old "warning" not relevant anymore. Same as in 1. but for the other OSs.

How to test this PR

Review.

@matsduf matsduf added this to the v2025.1 milestone Jun 23, 2025
@matsduf matsduf added the A-Documentation Area: Documentation only. label Jun 23, 2025
@marc-vanderwal

marc-vanderwal commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Looks good to me.

For context, the text this PR deletes was introduced almost 8 years ago in zonemaster/zonemaster-backend#344. I assume some bug in ExtUtils::MakeMaker, cpanm or something else has been fixed since, and in the past three years of release testing, I haven’t seen this failure scenario happen.

I think it’s safe to delete the same remark from the instructions in other OSes.

@matsduf

matsduf commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

I think it’s safe to delete the same remark from the instructions in other OSes.

Done.

@matsduf

matsduf commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

@marc-vanderwal, please re-review.

@matsduf matsduf merged commit 21e5190 into zonemaster:develop Jun 24, 2025
@matsduf matsduf deleted the update-backend-installation-instructions branch June 24, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattias-p mattias-p mattias-p approved these changes
@tgreenx tgreenx tgreenx approved these changes
@marc-vanderwal marc-vanderwal marc-vanderwal approved these changes
@tolvmannen tolvmannen Awaiting requested review from tolvmannen
@MichaelTimbert MichaelTimbert Awaiting requested review from MichaelTimbert

Assignees

No one assigned

Labels

A-Documentation Area: Documentation only.

Projects

None yet

Milestone

v2025.1

Development

Successfully merging this pull request may close these issues.

4 participants

@matsduf @marc-vanderwal @mattias-p @tgreenx