Adds four test scenarios (DNSSEC10)#1383
Merged
Merged
Conversation
marc-vanderwal
previously approved these changes
May 20, 2025
tgreenx
reviewed
May 20, 2025
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
Implemented in zonemaster/zonemaster-engine#1457
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
matsduf
commented
May 22, 2025
Contributor
Author
|
When zonemaster/zonemaster-engine#1457 is installed, the scenarios are clear, but there is unexpected result not captured by the test scenario model and unit tests: The zone is delegated to three NS, ns1a, ns1b and ns1c, but only the first one is listed under DS10_HAS_NSEC, |
Contributor
Author
|
In scenarios GOOD-NSEC-3 and GOOD-NSEC3-3 the names in delegation and names in zone are different. All should be listed in the argument. |
marc-vanderwal
approved these changes
May 28, 2025
tgreenx
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds four test scenarios (GOOD-NSEC-2, GOOD-NSEC-3, GOOD-NSEC3-2 and GOOD-NSEC3-3) that should pass, but fail due to a bug reported in zonemaster/zonemaster-engine#1454.
Context
zonemaster/zonemaster-engine#1454 (bug report)
zonemaster/zonemaster-engine#1457 (fix)
How to test this PR
Review the document and test the new scenarios in the test environment.