Add test zones for Address03#1354
Merged
marc-vanderwal merged 3 commits intoMay 20, 2025
Merged
Conversation
04b7675 to
1ebfc0a
Compare
matsduf
reviewed
Feb 25, 2025
1ebfc0a to
2523ef1
Compare
matsduf
requested changes
Feb 26, 2025
2523ef1 to
453b7fc
Compare
Contributor
Author
|
I’ve committed a new version of this PR, but I need to implement the two extra scenarios that I added in my last iteration. Feedback on the test zone specification is welcome! |
453b7fc to
40e9531
Compare
matsduf
previously approved these changes
Apr 28, 2025
tgreenx
reviewed
May 6, 2025
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
A few nits.
Also we should update the docs/public/SUMMARY.md file for the online documentation.
Address03 is missing test zone data. Let’s create it so that we can have proper unit tests for this test case. It will also help reproduce the issue described in zonemaster#1353. Note that the specification could use a rewrite. I’m basing it on what we currently have, but a specification update should also include an update of the test data. Although I think I’m already pretty complete.
40e9531 to
3654455
Compare
Contributor
Author
matsduf
approved these changes
May 7, 2025
tgreenx
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a handful of test scenarios in order to test the current implementation of Address03.
The test scenarios involve empty zones (except for SOA and NS resource records at the apex), with varying name servers which themselves have addresses which may or may not have associated PTR resource records.
Context
Attempt to reproduce the issue in #1353.
Changes
How to test this PR
N/A