Add test scenario CHILD-NS-CNAME-4#1348
Merged
marc-vanderwal merged 4 commits intoFeb 4, 2025
Merged
Conversation
Merge master into develop (zonemaster/zonemaster)
This scenario is similar to CHILD-NS-CNAME-1, but is a little bit more involved. Its real purpose is to help reproduce the issue documented in zonemaster-engine#1421. It is similar to a misconfigured zone seen “in the wild” that made Zonemaster::Engine’s resolver enter an infinite loop.
15911ce to
5b63c43
Compare
matsduf
approved these changes
Feb 3, 2025
tgreenx
approved these changes
Feb 3, 2025
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Note that I've changed the base branch to release-v2024.2.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a new test scenario to help reproduce the bug described in zonemaster/zonemaster-engine#1421. The fix in zonemaster/zonemaster-engine#1422 lacks unit tests at the time of writing and this PR should help adding one.
For now, I’ve verified that the scenario faithfully reproduces the bug and that the fix in Zonemaster-Engine also works with this scenario.
Context
See zonemaster/zonemaster-engine#1421 (bug description) and zonemaster/zonemaster-engine#1422 (fix).
Changes
How to test this PR
N/A.