Adjust dnssec10 spec and scenario#1341
Merged
matsduf merged 3 commits intoFeb 6, 2025
Merged
Conversation
…resulting in unwanted message tag
tgreenx
reviewed
Dec 19, 2024
Contributor
There was a problem hiding this comment.
I don't think the test_levels property should be set at all here, since it doesn't have any custom value. It also makes it more complicated to keep it in sync in case of changes. Setting just the net and test_cases properties should suffice.
Contributor
Author
There was a problem hiding this comment.
test_levels are set to make it possible to show that IPV6_DISABLED is output. This is for the display in the test-zones-output.md file. I do not see the issue.
For the unit test it is not necessary to change the level.
tgreenx
approved these changes
Jan 28, 2025
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
zonemaster/zonemaster-engine#1415 is updated with the changes from this PR.
mattias-p
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates DNSSEC10 specification to resolve #1340. It also adds test scenario BAD-SERVERS-BUT-GOOD-NSEC-1.
Besides this, it gives a way to test GOOD-NSEC-1 with IPv6 disabled (see test-zone-data/DNSSEC-TP/dnssec10/test-zones-output.md).
Context
#1340, zonemaster/zonemaster-engine#1415
How to test this PR
Review. The scenarios will be tested in updated zonemaster/zonemaster-engine#1415