Skip to content

Preparation for v2024.2 release (zonemaster/zonemaster)#1335

Merged
matsduf merged 6 commits into
zonemaster:developfrom
matsduf:preparation-release-v2024.2
Dec 9, 2024
Merged

Preparation for v2024.2 release (zonemaster/zonemaster)#1335
matsduf merged 6 commits into
zonemaster:developfrom
matsduf:preparation-release-v2024.2

Conversation

@matsduf

@matsduf matsduf commented Dec 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose

This PR is a preparation for v2024.2 release.

Changes

  • Changes
  • docs/public/RELEASE.md

RELEASE.md will also be used for the Github release page.

Excluded

The following PRs not yet merged have not been included:

How to test this PR

Review.

@matsduf matsduf added the A-Documentation Area: Documentation only. label Dec 8, 2024
@matsduf matsduf added this to the v2024.2 milestone Dec 8, 2024
@matsduf matsduf force-pushed the preparation-release-v2024.2 branch from 328c1fa to ac9b237 Compare December 8, 2024 16:50
@matsduf matsduf force-pushed the preparation-release-v2024.2 branch from ac9b237 to a632b70 Compare December 8, 2024 20:56
marc-vanderwal
marc-vanderwal reviewed Dec 9, 2024
View reviewed changes
Comment thread Changes Outdated
@matsduf @marc-vanderwal
Update Changes
69741b2 
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
marc-vanderwal
marc-vanderwal previously approved these changes Dec 9, 2024
View reviewed changes
tgreenx
tgreenx reviewed Dec 9, 2024
View reviewed changes

@tgreenx tgreenx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a mention here somewhere, maybe in Release information, that the documentation has been published as mdbook on doc.zonemaster.net for easier access to information.

Comment thread Changes Outdated
Comment thread Changes Outdated
Comment thread Changes Outdated
Comment thread Changes Outdated
Comment thread Changes Outdated
@matsduf @tgreenx
Apply suggestions from review
8824109 
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
marc-vanderwal
marc-vanderwal previously approved these changes Dec 9, 2024
View reviewed changes
@matsduf

matsduf commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

There should be a mention here somewhere, maybe in Release information, that the documentation has been published as mdbook on doc.zonemaster.net for easier access to information.

@tgreenx, I have updated with your suggestions. Please approve.

@tgreenx

tgreenx commented Dec 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

There should be a mention here somewhere, maybe in Release information, that the documentation has been published as mdbook on doc.zonemaster.net for easier access to information.

@tgreenx, I have updated with your suggestions. Please approve.

What about my main suggestion? What do you think? Could you take care of it? See below.

There should be a mention here somewhere, maybe in Release information, that the documentation has been published as mdbook on doc.zonemaster.net for easier access to information.

@matsduf

matsduf commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

What about my main suggestion? What do you think? Could you take care of it? See below.

I made a local mistake and did not see that I could not push. Now the update is pushed.

@matsduf

matsduf commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

@tgreenx and @marc-vanderwal, please re-approve.

mattias-p
mattias-p previously approved these changes Dec 9, 2024
View reviewed changes
tgreenx
tgreenx reviewed Dec 9, 2024
View reviewed changes
Comment thread Changes Outdated
Comment thread docs/public/RELEASE.md Outdated
@tgreenx tgreenx requested a review from mattias-p December 9, 2024 11:31
@matsduf matsduf merged commit 431438b into zonemaster:develop Dec 9, 2024
@matsduf matsduf deleted the preparation-release-v2024.2 branch December 10, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattias-p mattias-p mattias-p approved these changes
@tgreenx tgreenx tgreenx approved these changes
@tolvmannen tolvmannen Awaiting requested review from tolvmannen
@MichaelTimbert MichaelTimbert Awaiting requested review from MichaelTimbert
@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal

Assignees

No one assigned

Labels

A-Documentation Area: Documentation only.

Projects

None yet

Milestone

v2024.2

Development

Successfully merging this pull request may close these issues.

4 participants

@matsduf @tgreenx @mattias-p @marc-vanderwal