Skip to content

Updates CLI installation instruction#1321

Merged
matsduf merged 5 commits into
zonemaster:developfrom
matsduf:de-Moose-CLI-installation
Nov 26, 2024
Merged

Updates CLI installation instruction#1321
matsduf merged 5 commits into
zonemaster:developfrom
matsduf:de-Moose-CLI-installation

Conversation

@matsduf

@matsduf matsduf commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Purpose

  1. Moose has been removed from CLI, which means that it is no longer a dependency.
  2. JSON::Validator is a new dependency.
  3. User installation should be done without testing, by default.

Context

  1. Make usage documentation consistent and also demoose zonemaster-cli#371

How to test this PR

  1. Review
  2. Use the instruction and verify
    1. that no extra dependencies are pulled in by cpanm from CPAN
    2. that CLI works.

@matsduf matsduf added T-Bug Type: Bug in software or error in test case description A-Documentation Area: Documentation only. labels Nov 26, 2024
@matsduf matsduf added this to the v2024.2 milestone Nov 26, 2024
marc-vanderwal
marc-vanderwal previously approved these changes Nov 26, 2024

@marc-vanderwal marc-vanderwal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted perl-MooseX-Getopt from my Rocky 9 test VM (which also removes all of the now-unused dependencies from the system). zonemaster-cli still works.

@matsduf matsduf changed the title De-Moose CLI installation instruction Updates CLI installation instruction Nov 26, 2024
@matsduf

matsduf commented Nov 26, 2024

Copy link
Copy Markdown
Contributor Author

@marc-vanderwal, please read this PR again. I have expanded it.

@matsduf

matsduf commented Nov 26, 2024

Copy link
Copy Markdown
Contributor Author

@marc-vanderwal, is JSON::Validator available as binary dependancy for Rocky?

@marc-vanderwal

Copy link
Copy Markdown
Contributor

@marc-vanderwal, is JSON::Validator available as binary dependancy for Rocky?

No, it isn’t, but its own dependencies are: perl-Test-Deep and perl-Mojolicious. These two can be installed in order to avoid pulling them from CPAN.

@matsduf

matsduf commented Nov 26, 2024

Copy link
Copy Markdown
Contributor Author

No, it isn’t, but its own dependencies are: perl-Test-Deep and perl-Mojolicious. These two can be installed in order to avoid pulling them from CPAN.

@marc-vanderwal, thanks. Please re-review.

tgreenx
tgreenx previously approved these changes Nov 26, 2024
Comment thread docs/public/installation/zonemaster-cli.md Outdated
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Comment thread docs/public/installation/zonemaster-cli.md Outdated
Comment thread docs/public/installation/zonemaster-cli.md Outdated
Comment thread docs/public/installation/zonemaster-cli.md Outdated
Comment thread docs/public/installation/zonemaster-cli.md Outdated
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
@matsduf matsduf merged commit f40b281 into zonemaster:develop Nov 26, 2024
@matsduf matsduf deleted the de-Moose-CLI-installation branch November 26, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Documentation Area: Documentation only. T-Bug Type: Bug in software or error in test case description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants