Updates UDP DNS size default value and adds text about it#1316
Merged
matsduf merged 3 commits intoNov 26, 2024
Conversation
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
marc-vanderwal
previously approved these changes
Nov 21, 2024
tgreenx
reviewed
Nov 21, 2024
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
One small suggestion otherwise LGTM
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Contributor
Author
|
@tgreenx and @marc-vanderwal, please re-approve! |
marc-vanderwal
approved these changes
Nov 25, 2024
tgreenx
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the default UDP DNS value and adds an explanation to the choice of the values.
How to test this PR
Review.