Creates test scenarios and test zones for test cases Delegation01, -02 and -03#1305
Merged
matsduf merged 20 commits intoDec 3, 2024
Merged
Conversation
b2fb2f0 to
06bfa47
Compare
06bfa47 to
90d16eb
Compare
tolvmannen
reviewed
Nov 8, 2024
Contributor
Author
|
@mattias-p, @marc-vanderwal, @tolvmannen, @tgreenx -- please review. |
mattias-p
reviewed
Nov 14, 2024
mattias-p
left a comment
Member
There was a problem hiding this comment.
I've only read through the markdown files and noted things I saw as I passed by. It's a big PR, but if you want I can go through it again more thoroughly.
Co-authored-by: Mattias Päivärinta <mattias@paivarinta.se>
mattias-p
reviewed
Nov 15, 2024
mattias-p
left a comment
Member
There was a problem hiding this comment.
I looked through the documentation again. I found a bunch of details to comment on, but overall it looks really good.
| Missing glue, only IPv4 on ns1 and only IPv6 on ns2. | ||
|
|
||
| * Zone: mismatch-delegation-child-1.delegation01.xa | ||
| * Both ns1 and ns2 in delegation. |
Member
There was a problem hiding this comment.
Could this item be removed? It changes nothing compared to ENOUGH-1, right?
| The zone has only IPv4 on ns1 and only IPv6 on ns2. | ||
|
|
||
| * Zone: mismatch-delegation-child-2.delegation01.xa | ||
| * Both ns1 and ns2 in zone. |
Member
There was a problem hiding this comment.
Could this item be removed? It changes nothing compared to ENOUGH-1, right?
| addresses, respectively. | ||
| * ns1a and ns1b have distinct addresses in the zone (IPv4 and IPv6, | ||
| respectively). | ||
| * Undelegated data: |
Member
There was a problem hiding this comment.
I'm not sure how to interpret this item. Maybe I've missed something or maybe it could use a few more words of explanation.
Contributor
Author
There was a problem hiding this comment.
I have added a section to the "test scenario README file" referred to from this file. The update is included in this PR.
Co-authored-by: Mattias Päivärinta <mattias@paivarinta.se>
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Contributor
Author
|
@marc-vanderwal, please re-review. |
marc-vanderwal
previously approved these changes
Nov 25, 2024
tgreenx
reviewed
Nov 26, 2024
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
The file docs/public/SUMMARY.md should be updated too.
| * All addresses are distinct | ||
| * All required glue are present in the delegation. | ||
| * There is no actual zone or zone file, only a delegation. | ||
| * For this test, that the zone is missing is disregarded. |
Contributor
There was a problem hiding this comment.
I'm not sure of the intended meaning here for my suggestion, but it surely needs a rephrase.
Suggested change
| * For this test, that the zone is missing is disregarded. | |
| * For this test, that the missing zone is disregarded. |
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Contributor
Author
|
Resolved conflict that was created when #1294 was merged. @tgreenx and @marc-vanderwal, please review/approve. |
marc-vanderwal
approved these changes
Nov 27, 2024
tgreenx
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR defines test scenarios and create test zones for test cases
New unit tests bases in this work have been created in zonemaster/zonemaster-engine#1395.
The implementation of Delegation02 also outputs tags SAME_IP_ADDRESS or DISTINCT_IP_ADDRESS. Those are however not defined in the test case specification, and they are disregarded for the scenarios. They do not seem to add any information to the result.
The unit tests created from these scenarios will replace legacy unit tests.
Context
zonemaster/zonemaster-engine#1395
How to test this PR
Review.