Skip to content

Clarify MethodsV2?#1290

Merged
matsduf merged 2 commits into
zonemaster:developfrom
matsduf:clarify-methodsv2
Sep 9, 2024
Merged

Clarify MethodsV2?#1290
matsduf merged 2 commits into
zonemaster:developfrom
matsduf:clarify-methodsv2

Conversation

@matsduf

@matsduf matsduf commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

Purpose

This PR makes it explicit that CNAME should be followed. Does this match the implementation

How to test this PR

Review the change and judge if the change is desired and if it matches the implementation.

@matsduf matsduf added this to the v2024.2 milestone Aug 28, 2024
@matsduf matsduf requested a review from tgreenx August 28, 2024 14:36
@matsduf matsduf force-pushed the clarify-methodsv2 branch from 47d81f3 to b368ba7 Compare August 28, 2024 14:44
@tgreenx tgreenx added the A-Documentation Area: Documentation only. label Aug 28, 2024
tgreenx
tgreenx previously approved these changes Sep 4, 2024
@marc-vanderwal

Copy link
Copy Markdown
Contributor

In this context, we are resolving A and AAAA resource records for names that we found in NS records, right? Yet, RFC 2181, § 10.3 disallows pointing to an alias from an NS record. If anything, Zonemaster should report an error in this situation, instead of following CNAMEs.

@matsduf

matsduf commented Sep 5, 2024

Copy link
Copy Markdown
Contributor Author

Yet, RFC 2181, § 10.3 disallows pointing to an alias from an NS record. If anything, Zonemaster should report an error in this situation, instead of following CNAMEs.

It is correct that the hostname in the RDATA of an NS record must not have a CNAME record, and Bind will not follow a CNAME. This is the method collecting as many name servers for the zone as possible to be able report as many issues as possible. The methods do not report any issues at all. That is up to the test cases to do.

Delegation05 checks if the name server names has a CNAME record, and if so outputs NS_IS_CNAME on ERROR level

@marc-vanderwal

Copy link
Copy Markdown
Contributor

Okay, then I understand the rationale. I’d just suggest adding a remark on why Zonemaster follows aliases in that specific case, even though NS records aren’t supposed to point to any. Then it should be fine.

@matsduf

matsduf commented Sep 5, 2024

Copy link
Copy Markdown
Contributor Author

A clarification of the resolution of CNAME has been added. @marc-vanderwal @tgreenx, please re-review.

@matsduf matsduf requested a review from tgreenx September 5, 2024 15:20
@matsduf

matsduf commented Sep 9, 2024

Copy link
Copy Markdown
Contributor Author

@tgreenx, can I just merge? Is any update in the implementation needed?

@tgreenx

tgreenx commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

@tgreenx, can I just merge? Is any update in the implementation needed?

Yes you can, Zonemaster now follows CNAME in recursive queries (zonemaster/zonemaster-engine#1288).

@matsduf matsduf merged commit 206af90 into zonemaster:develop Sep 9, 2024
@matsduf matsduf deleted the clarify-methodsv2 branch September 9, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Documentation Area: Documentation only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants