Adds test scenarios for Consistency05 and Consisteny06#1266
Merged
matsduf merged 11 commits intoMay 22, 2024
Conversation
…ofile to give better output.
…ofile to give better output.
marc-vanderwal
left a comment
Contributor
There was a problem hiding this comment.
Looks fine. I just noticed a few typos.
| * Delegated zone on ns1 and ns2. | ||
| * Undelegated zon on ns3 and ns4. | ||
| * Delegated zone has neither ns1, ns2, ns3 or ns4 as address records. | ||
| * Undelegated zone does not have ns1 and ns2 as address records, but it |
Contributor
There was a problem hiding this comment.
Do you mean that the undelegated zone can have ns1 or ns2 but not both? Or that it should have neither ns1 nor ns2?
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Contributor
Author
|
@marc-vanderwal and @tgreenx, zonemaster/zonemaster-engine#1340 has been merged and it partly built on this PR. Can this be merged? |
marc-vanderwal
approved these changes
May 22, 2024
tgreenx
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR contains the specification of new test scenarios (five for Consistency05 and two for consistency06) that have been added as unit tests in zonemaster/zonemaster-engine#1340.
Context
zonemaster/zonemaster-engine#1340
How to test this PR
Review and test