Change supported way of extracting default profile in Engine#1262
Merged
Conversation
matsduf
reviewed
May 3, 2024
matsduf
requested changes
May 4, 2024
b113823 to
00fa392
Compare
matsduf
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR replaces the supported method of extracting the default profile from Zonemaster Engine.
Context
Together with zonemaster/zonemaster-engine#1339 this PR fixes zonemaster/zonemaster-engine#1333, which is a step towards zonemaster/zonemaster-engine#1337.
Changes
This is a breaking change in Zonemaster Engine because it removes the installed
profile.jsonfile from the public interface. Instead of copying or inspecting this file directly, users are instructed to extract it from Zonemaster::Engine.How to test this PR
Test the commands to extract the default profile in
docs/public/configuration/profiles.mdanddocs/public/configuration/global-cache.md.