Test scenarios for MethodsV2 by matsduf · Pull Request #1254 · zonemaster/zonemaster

matsduf · 2024-04-17T08:26:52Z

Purpose

This PR provides test scenarios for MethodsV2. They have been implemented in zonemaster/zonemaster-engine#1351.

How to test this PR

Review
Load the test zone environment and check by using dig

…se test scenarios

…o be easier to work with

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

* Updates to match updated specification where NXDOMAIN and NODAT for the tested domain is ignored. * Introduce a distinction between "empty" and "undefined" for some sets without members, e.g. set of parent NS IP.

marc-vanderwal · 2024-07-15T06:33:29Z

+
+
+
+$ORIGIN parent            ; Must be relative


Are relative domain names allowed in $ORIGIN directives? I doubt it, and I know nsd would reject such a directive.

They are permitted. There is nothing in RFC 1035 forbidding the domain name after $ORIGIN. There is nothing special about the "" after $ORIGIN.

And CoreDNS has no problem with that. I pretty sure that also Bind supports it.

marc-vanderwal · 2024-07-15T06:34:42Z

+
+## Root hint for scenarios
+
+For all scenarios the root hint should be


Just a minor cosmetic detail, but it feels more correct to name the root servers something like ns1.root-servers.xa instead of a TLD.

It is nothing that could be changed here since that is part of the entire framework.

It does not disturb me, but having names with at least two labels before the final dot would work too, and it is more like you would expect. I can change it later in a PR that must be coordinated with a PR to Zonemaster-Engine too, and with a quick review and merge.

Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>

matsduf

@marc-vanderwal, thank you for a thorough review into the details.

matsduf · 2024-07-16T18:52:42Z

+* Zone: child.parent.chld-found-inconsist-6.methodsv2.xa
+  * Parent `ns1` has normal delegation of child to the two child NS.
+  * Parent `ns2` lacks delegation of child (NXDOMAIN).
+  * Child shares `ns1.parent.chld-found-inconsist-6.methodsv2.xa` with parent.


Yes, on parent ns1 (ns1.parent.chld-found-inconsist-6.methodsv2.xa).

matsduf · 2024-07-16T18:54:38Z

+  * Parent `ns1` has normal delegation of child to the two child NS.
+  * Parent `ns2` lacks delegation of child (NXDOMAIN).
+  * Child shares `ns1.parent.chld-found-inconsist-6.methodsv2.xa` with parent.
+  * Child also uses child `ns1` and `ns2`.


Child is also hosted on ns1 and ns2 (the default ns1 and ns2 for a child).

matsduf · 2024-07-16T18:56:33Z

+other there is a NODATA response.
+
+* Zone: child.parent.chld-found-inconsist-10.methodsv2.xa
+  * Parent `ns1` has normal delegation of child to two child NS, `ns1` and `ns2`.


Here "child" refer to the relation not the name. Both "child" and "parent" are used as relations here.

matsduf · 2024-07-16T19:01:50Z

+  * Normal response on grandparent `ns1`.
+  * Grandparent `ns2` responds with other owner name on NS query for
+    `zone-err-grandparent-3.methodsv2.xa`:
+      * Owner name `oncle.zone-err-grandparent-3.methodsv2.xa` instead.


I agree that "uncle" is the expected, but it is just a name. The name in the configuration is also "oncle". It should match.

matsduf · 2024-07-16T19:08:58Z

+
+
+
+$ORIGIN parent            ; Must be relative


They are permitted. There is nothing in RFC 1035 forbidding the domain name after $ORIGIN. There is nothing special about the "" after $ORIGIN.

And CoreDNS has no problem with that. I pretty sure that also Bind supports it.

matsduf · 2024-07-16T19:15:51Z

+
+## Root hint for scenarios
+
+For all scenarios the root hint should be


It is nothing that could be changed here since that is part of the entire framework.

It does not disturb me, but having names with at least two labels before the final dot would work too, and it is more like you would expect. I can change it later in a PR that must be coordinated with a PR to Zonemaster-Engine too, and with a quick review and merge.

tgreenx · 2024-07-17T16:27:12Z

+Test zone specifications for the following methods are available (work in
+progress):
+
+[Get parent NS IP addresses](get-parent-ns-ip-addresses.md)


This link should be created, or removed.

tgreenx · 2024-07-17T17:00:07Z

+* [Undelegated data for scenarios](#undelegated-data-for-scenarios)
+* [Data type in method output](#data-type-in-method-output)
+* [Scenarios](#scenarios)
+  * [GOOD-1](#good-1)


This table should be updated with all scenarios.

I'll create.

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Test scenarios for MethodsV2

91b91ca

matsduf added the FA-MethodV2 label Apr 17, 2024

matsduf added this to the v2024.1 milestone Apr 17, 2024

matsduf requested a review from tgreenx April 17, 2024 08:26

matsduf added 2 commits April 17, 2024 11:43

Updates scripts for starting and starting information

db72f76

Editorial updates and fixes typos

561aba3

matsduf force-pushed the test-zones-methodv2 branch from b87c12a to 561aba3 Compare April 22, 2024 10:24

Additional scenarios defined

bcdf255

tgreenx mentioned this pull request Apr 30, 2024

Create test zones and test data for MethodsV2. zonemaster/zonemaster-engine#1222

Closed

tgreenx reviewed May 21, 2024

View reviewed changes

Comment thread test-zone-data/MethodsV2/child.parent.good-undel-2.methodsv2.xa_UNDEL Outdated

Corrects IP address

ce29d27

tgreenx mentioned this pull request May 22, 2024

Add MethodsV2 unit testing zonemaster/zonemaster-engine#1350

Merged

matsduf added 3 commits May 24, 2024 13:18

Renames file to have the same name as the equivalent file for test ca…

08ba74d

…se test scenarios

Gives zone files a .zone extension

c70cde6

Renumbers the addresses to be in line with test case test zones and t…

12c3b33

…o be easier to work with

matsduf mentioned this pull request May 26, 2024

Renumbers addresses and creates new data file tgreenx/zonemaster-engine#2

Closed

matsduf added 4 commits May 27, 2024 12:46

Simplies zones

c538d90

Corrects IP address

ddf7c32

Restructures and simplifies documentation

e758199

Restructures and adds more scenarios

292f3d5

matsduf mentioned this pull request May 27, 2024

Updates methodsv2 unit tests zonemaster/zonemaster-engine#1351

Merged

matsduf added 3 commits May 29, 2024 12:00

Adds more scenarios

99bdd5c

Adds more scenarios

6b0bc8f

Adds more scenarios and updates some

bb44199

tgreenx modified the milestones: v2024.1, v2024.2 Jun 11, 2024

matsduf mentioned this pull request Jul 5, 2024

Update MethodsV2 to match Basic01 #1287

Merged

matsduf added 2 commits July 11, 2024 11:19

Updates the scenarios and adds test zones

c0f50e0

Updates to match adjusted algorithm to extract parent IP

1f36cfa

tgreenx reviewed Jul 11, 2024

View reviewed changes

Merge branch 'develop' into test-zones-methodv2

abbe73f

tgreenx mentioned this pull request Jul 11, 2024

Update MethodsV2 get_parent_ns_ips() to match new Basic01 algorithm zonemaster/zonemaster-engine#1373

Merged

Apply suggestions from code review

065607f

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

matsduf requested a review from tgreenx July 11, 2024 16:52

matsduf added 2 commits July 11, 2024 21:26

Updates test scenarier

9e923b1

* Updates to match updated specification where NXDOMAIN and NODAT for the tested domain is ignored. * Introduce a distinction between "empty" and "undefined" for some sets without members, e.g. set of parent NS IP.

Adds and updates scenarios and test zones

6348529

matsduf requested review from MichaelTimbert, marc-vanderwal and mattias-p July 12, 2024 20:00

marc-vanderwal reviewed Jul 15, 2024

View reviewed changes

Apply suggestions from document review

35018fa

Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>

matsduf commented Jul 16, 2024

View reviewed changes

matsduf requested a review from marc-vanderwal July 16, 2024 19:23

tgreenx reviewed Jul 17, 2024

View reviewed changes

matsduf and others added 3 commits July 18, 2024 15:59

Apply suggestions from code review

d39f8c3

Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>

Editorial updates

daca31e

Editorial updates

d86342e

matsduf requested a review from tgreenx July 18, 2024 14:39

tgreenx approved these changes Jul 23, 2024

View reviewed changes

matsduf merged commit 44f7e3e into zonemaster:develop Jul 23, 2024

matsduf deleted the test-zones-methodv2 branch July 23, 2024 14:14


		## Root hint for scenarios

		For all scenarios the root hint should be

Uh oh!

Conversation

matsduf commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

How to test this PR

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

matsduf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

matsduf commented Apr 17, 2024 •

edited

Loading